feat(table): added max-height to outerscroll #5039
Conversation
|
Preview: https://patternfly-pr-5039.surge.sh A11y report: https://patternfly-pr-5039-a11y.surge.sh |
|
|
||
| display: flex; | ||
| flex-direction: column; | ||
| max-width: 100%; | ||
| height: 100%; |
There was a problem hiding this comment.
did you mean to add this? I don't see reference to it and looks like it could change an existing layout if the min-height was unset to allow a table to grow to the max-height, then start scrolling.
min-height auto
^ w/ height: 100%
From what I tested, height: 100% doesn't seem necessary (at least in the codesandbox @kmcfaul created), but I don't know all of the use cases.
There was a problem hiding this comment.
did you mean to add this?
@mcoker oops, nope
|
🎉 This PR is included in version 4.209.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@mattnolting @kmcfaul do we want to add a prop or anything for the min/max-heights, or just leave them as CSS vars? If y'all want to add a prop, would you mind creating an issue for that in the patternfly-react repo? Unless one exists already - I looked and didn't see one. |
closes #5038