Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(table): added max-height to outerscroll #5039

Merged
merged 2 commits into from Aug 19, 2022
Merged

feat(table): added max-height to outerscroll #5039

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7dde92
feat(table): added max-height to outerscroll
mattnolting Aug 17, 2022
8ee6337
update
mattnolting Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/patternfly/components/Table/table-scrollable.scss
View file
Open in desktop
Expand Up @@ -43,12 +43,14 @@

.pf-c-scroll-outer-wrapper {
--pf-c-scroll-outer-wrapper--MinHeight: #{pf-size-prem(400px)};
--pf-c-scroll-outer-wrapper--MaxHeight: 100%;

display: flex;
flex-direction: column;
max-width: 100%;
height: 100%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean to add this? I don't see reference to it and looks like it could change an existing layout if the min-height was unset to allow a table to grow to the max-height, then start scrolling.

min-height auto

Screen Shot 2022-08-18 at 5 56 29 PM

^ w/ height: 100%

Screen Shot 2022-08-18 at 5 56 33 PM

From what I tested, height: 100% doesn't seem necessary (at least in the codesandbox @kmcfaul created), but I don't know all of the use cases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean to add this?

@mcoker oops, nope

min-height: var(--pf-c-scroll-outer-wrapper--MinHeight);
max-height: 100%;
max-height: var(--pf-c-scroll-outer-wrapper--MaxHeight);
overflow: hidden;
}

Expand Down