fix(global): remove woff, use where with globals, cleanup #5435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcoker
force-pushed
the
v5-globals-woff-cleanup
branch
from
814fac6
to
9788102
Compare
|
Preview: https://patternfly-pr-5435.surge.sh A11y report: https://patternfly-pr-5435-a11y.surge.sh |
|
I see a difference in masthead - |
|
There's a slightly different background on dark theme card (actually I think many dark theme) demos |
@srambach that's from removing the
That's to be expected, the old styles were from previous design iterations on buttons. |
|
Actually though - that primary button doesn't pass the contrast check. |
|
🎉 This PR is included in version 5.0.0-alpha.34 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
May 18, 2023
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:where()around global (normalize and reset) styles. This removes the specificity from these rules, so they will not fight for specificity with any selector styles with a specificity > 0 - from our components or any user overrides.[class*=pf-c-], [class*=pf-c-]::before, [class*=pf-c-]::after { padding/margin: 0; background: transparent; }, but those were removed for v5 in another PR. However, I think this may be good practice in general for PF and users to be able to easily override any base/global styles without having to fight for specificity or put styles in an appropriate layer (in the future).h1, a, body, etcand loads PF afterward - our styles will currently override those styles (assuming our specificity is >= and the rules match 1:1), and they will not if we wrap our styles in:where(). Though I think that kind of conflict is something that should be handled on a case by case basis when importing multiple global styles as there are likely multiple conflicts like that regardless of using:where()