fix(button): fixes primary background in pf-t-dark block #5652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-pr-5652.surge.sh A11y report: https://patternfly-pr-5652-a11y.surge.sh |
thatblindgeye
approved these changes
Jun 8, 2023
mceledonia
approved these changes
Jun 8, 2023
|
🎉 This PR is included in version 5.0.0-prerelease.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 6.0.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5436
This PR addresses the custom primary and secondary button styles that were removed from the
pf-t-darkplaceholder in #5435You can see what the old styles looked like when a primary or secondary button was used in a "dark" block, which were based off of an old design here - https://www.patternfly.org/v4/components/masthead/html#basic-with-mixed-content
This PR just re-introduces a var override in the placeholder that sets the primary button background, and resets it in dark theme's placeholder. The secondary button is already accessible in a dark block, so no override is necessary. Here's that demo in this PR - https://patternfly-pr-5652.surge.sh/components/masthead#basic-with-mixed-content