chore(menu-toggle): updated demos to use menu-toggle #5782

mattnolting · 2023-07-26T16:50:21Z

closes #5764

patternfly-build · 2023-07-26T16:56:44Z

Preview: https://patternfly-pr-5782.surge.sh

A11y report: https://patternfly-pr-5782-a11y.surge.sh

thatblindgeye

The ID's for the toolbar examples will need to be updated to be unique as well.

Some other things I noticed which may be out of scope, in which case we can do a followup if necessary

There's still some usage of the deprecated dropdown, such as Selected filters on mobile (kebab button).
The "filter" plain toggle in some examples is just using the PF button instead of a MenuToggle; this is both Core and React, though cc @mcoker

src/patternfly/components/MenuToggle/menu-toggle.hbs

src/patternfly/components/Toolbar/toolbar-item-bulk-select.hbs

mcoker

Massive! Just a few comments.

src/patternfly/components/Panel/panel.hbs

mcoker · 2023-10-05T14:13:54Z

src/patternfly/components/Toolbar/toolbar-item.hbs

+  {{#if toolbar-item--IsRelative}}
+    style="position: relative;"
+  {{/if}}


Same here about this local style - can it be moved to local demo styles if it's necessary? Also could we just not show expanded menus in core since the tools used to position those no longer lives in the CSS?

mcoker · 2023-10-05T14:17:13Z

src/patternfly/components/Toolbar/toolbar.scss

+  .#{$panel} {
+    --#{$panel}--MinWidth: 100%;
+  }


Can you point link to the examples where this is used? I'm wondering if we need to scope this style further so it doesn't do anything we don't intend.

Ping - didn't see a reply here. Similar to the menu toggle comment, I'm curious if this is fixing a known bug and if this might do something we don't want it to since it has a broad scope. If it's a bug fix/enhancement, can we move it into another issue?

mcoker · 2023-10-05T14:17:50Z

src/patternfly/components/Toolbar/toolbar.scss

+  .#{$menu-toggle} {
+    width: 100%;
+  }


Same here - can you link to where this is seen? I'm wondering if this needs to be further scoped to not do something unexpected.

With toggle at 100%

Ah, thanks! I think that should be a separate issue and we can see how to handle that. Filed an isssue here - #6008

I think we used to get this for free because a select was used there, and the select toggle width is 100%? I'm wondering if:

there is ever a use case for a menu toggle that isn't a select - meaning we might not want to style all menu toggles this way

the react examples have a fixed width assigned to the filters in the expanded content - https://www.patternfly.org/components/toolbar. Is that on purpose? If they should be full-width, should that be something the react <Select> component sets by default? Or should we encourage the use of .pf-m-full-width on the menu toggle for those filters in our examples (change the fixed width to the full width modifier)

mcoker · 2023-10-06T05:02:09Z

Here's the backstop report

Split button menu toggles - it's known/expected those are wider in the menu toggle than in dropdown
Menu toggles in the masthead have a transparent background - I think that's how they were originally intended to look anyways
Extra space in menu items with checkboxes - left a comment/code suggestion to address that
Toolbar filter toggle icon changed from grey to black - left a comment to address that
There is extra space between toolbar expandable content filter labels the stuff below them - left a comment

src/patternfly/components/Menu/menu-item.hbs

mcoker · 2023-10-06T04:45:55Z

src/patternfly/components/Toolbar/toolbar-toggle.hbs

@@ -2,11 +2,11 @@
  {{#if toolbar-toggle--attribute}}
    {{{toolbar-toggle--attribute}}}
  {{/if}}>
-  {{#> button button--modifier="pf-m-plain" button--attribute=(concat 'aria-label="Show filters" aria-expanded="' toolbar-toggle--IsExpanded '" aria-controls="' toolbar--id '-expandable-content"')}}
+  {{#> menu-toggle menu-toggle--IsPlain=true menu-toggle--IsExpanded=toolbar-toggle--IsExpanded menu-toggle--attribute=(concat 'aria-label="Show filters" aria-controls="' toolbar--id '-expandable-content"')}}


This toggle has the expanded modifier when the expanded content isn't expanded. Looks to be from the way this is set -

patternfly/src/patternfly/demos/Toolbar/toolbar-template.hbs

Line 38 in c06eca9

{{> toolbar-toggle toolbar-toggle--IsExpanded="false"}}

Since it's set to the string "false", the param is returning true, so menu-toggle--IsExpanded=toolbar-toggle--IsExpanded makes menu-toggle--IsExpanded return true. We probably just need to update that to toolbar-toggle--IsExpanded=false, though the string "false" was being used here to provide the value for aria-expanded. We'd want to double check toolbar-toggle--IsExpanded="false" wasn't used for the string "false" anywhere else.

src/patternfly/components/Toolbar/toolbar.scss

mcoker

Screenshots look good! Left 2 comments about the SCSS changes that could have an unintended impact. I filed a separate issue for the menu toggles in toolbar expanded content - I'd like to have core/react review that and see what the best solution is. And left a comment about a panel style that was added - can you review and lemme know what you think?

mcoker · 2023-10-18T03:51:45Z

src/patternfly/components/Toolbar/toolbar.scss

+  .#{$menu-toggle} {
+    width: 100%;
+  }


Ah, thanks! I think that should be a separate issue and we can see how to handle that. Filed an isssue here - #6008

I think we used to get this for free because a select was used there, and the select toggle width is 100%? I'm wondering if:

there is ever a use case for a menu toggle that isn't a select - meaning we might not want to style all menu toggles this way

the react examples have a fixed width assigned to the filters in the expanded content - https://www.patternfly.org/components/toolbar. Is that on purpose? If they should be full-width, should that be something the react <Select> component sets by default? Or should we encourage the use of .pf-m-full-width on the menu toggle for those filters in our examples (change the fixed width to the full width modifier)

mcoker · 2023-10-18T03:53:38Z

src/patternfly/components/Toolbar/toolbar.scss

+  .#{$panel} {
+    --#{$panel}--MinWidth: 100%;
+  }


Ping - didn't see a reply here. Similar to the menu toggle comment, I'm curious if this is fixing a known bug and if this might do something we don't want it to since it has a broad scope. If it's a bug fix/enhancement, can we move it into another issue?

mcoker

🎃👍
👖
🛼

patternfly-build · 2023-10-27T19:49:44Z

🎉 This PR is included in version 5.2.0-prerelease.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

* chore(select): fixed text in HTML example to show multiple checks can be selected (#5663) * chore: Update release.yml to node 18 [ci skip] * chore: add superclean npm script (#5798) * chore(options-menu): updated markup to match react component (#5809) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.3 (#5720) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): bump semver from 5.7.1 to 5.7.2 (#5756) Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: updated use of flex start/end to be more compatible (#5807) * fix(chip): add margin for badge when used in text element (#5844) * feat(global): added RTL support (#5778) * fix: added tree view icon (#5845) * fix: added tree view icon * chore: put treeviewicon in alphabetical order * chore: rtl fixes, screenshots (#5854) * chore: rtl fixes, screenshots * chore: checkin screenshots * chore(deps): update dependency @patternfly/documentation-framework to v5.1.7 (#5852) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: enable RTL switcher on full page examples (#5859) * docs: update location of and references to docs to consolidate and organize information. (#5773) * fix: added base, wizard, pagination RTL styles (#5860) * chore(Accordion,ExpandableSection): added more RTL styling (#5861) * fix(RTL): refactor mixins, add slider rtl styles (#5867) * fix(nav): added optional text wrapper for nav text (#5868) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.9 (#5863) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(Toolbar): updated toolbar pagination structure (#5862) * fix(breadcrumb): added rtl support (#5870) * chore(card): updated horiz demo image (#5875) * chore(Alert,NotificationDrawer): added additional rtl styling (#5866) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.10 (#5880) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(Nav, Menu): apply RTL fixes (#5873) * fix(clipboard-copy): added rtl styles (#5876) * fix(page): added rtl styles (#5878) * fix(calendar-month): rtl support (#5869) * chore(Card,Tile): apply RTL fixes (#5881) * fix: added tabs and jump links rtl styles (#5877) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.11 (#5885) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(DataList): added additional rtl styling (#5871) * chore(DataList): added additional rtl styling * Add comment to update notif badge in breaking change * fix(popover, tooltip): added rtl styles (#5882) * fix(tree-view): added rtl styles (#5883) * chore(Table): added additional RTL styling (#5887) * chore(Drawer): transforms and shadows on RTL drawer (#5888) * fix(forms): updated rtl styles (#5889) * fix(skeleton): added rtl styles (#5891) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.12 (#5894) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(slider): added root decl for var to create react token (#5895) * chore(ModalBox): center modal for workspace in RTL (#5893) * fix(rtl): fixes truncate rtl (#5874) * fix(ModalBox): fix centering on mobile (#5905) * chore: added backstop as dev dependency, update config (#5904) * chore(popover): center examples (#5906) * fix(nav): updated example css (#5903) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.14 (#5909) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: remove workspace RTL classes (#5912) * chore: update screenshots (#5915) * fix: Update upload-preview.js to use new workspace url * chore(deps): update dependency @patternfly/documentation-framework to v5.1.15 (#5916) * chore(deps): update dependency @patternfly/react-table to v5.0.1 (#5914) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-code-editor to v5.0.1 (#5910) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-core to v5.0.1 (#5913) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: mirror fa-sort icon (#5920) * fix: mirror bg image position in rtl (#5922) * fix(progress): updated indicator direction (#5923) * chore: update readme to reference new workspace url * chore(deps): update dependency @patternfly/documentation-framework to v5.2.0 (#5925) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(code-editor): make code box and header LTR (#5928) * fix(code-editor): make code box and header LTR * chore: refactor to use dir instead of css for ltr on code block * fix(banner): fixed invalid dark theme color declaration (#5933) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.2 (#5934) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/documentation-framework to v5.2.3 (#5940) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(clipboard-copy): add code example with rtl support (#5941) * fix(card): removed border from clickable/selectable selected (#5935) * feat(Button): extended inline styling (#5696) * fix(menu): updated drilldown breadcrumb menu icons to work in RTL (#5924) * fix(toolbar): fix expand all icon in RTL (#5937) * chore(toolbar): mirror expand all icon in rtl * chore: update * chore: use icon shouldMirrorRTL param * fix(popover/tooltip): revert arrow logical prop positioning (#5952) * fix(popover/tooltip): revert arrow logical prop positioning * chore: add missing local css import * chore(screenshots): updated full page screenshots (#5960) * chore(deps): update dependency @patternfly/react-core to v5.1.1 (#5975) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps-dev): bump postcss from 8.4.27 to 8.4.31 (#5971) * chore(Toolbar): increase workspace container height (#5962) * chore(screenshots): update visual regression screenshots (#5959) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.17 (#5961) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-table to v5.1.1 (#5977) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-code-editor to v5.1.1 (#5974) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(check-radio): added aria-describedby to check/radio (#5969) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.18 (#5982) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(brand/card): update examples to display logo in dark theme (#5681) * fix(input): standardized check and radio alignment (#5947) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.19 (#5985) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/documentation-framework to v5.2.20 (#5994) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): bump @babel/traverse from 7.22.15 to 7.23.2 (#6001) Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.15 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(Switch): updated focus style to focus-visible (#5995) * chore(menu-toggle): updated demos to use menu-toggle (#5782) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.24 (#6014) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(Accordion): added left-aligned toggle variant (#5987) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.26 (#6020) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: V6 merge main.10.30 (#6023) * chore(deps): update dependency @patternfly/documentation-framework to v5.3.0 (#6027) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(main): reverts to pre-v6 merge (#6038) * chore(deps): update dependency @patternfly/documentation-framework to v5.3.1 (#6040) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(globals): update invalid selector in global css (#6044) * feat(breaker): bump this version to 6.0 (#5800) BREAKING CHANGE: 6.0.0-alpha.0 * fix: white space change to kick off dry run * fix: use prerelease tag format with dry run * fix: turn off dryrun * feat(tokens): add initial global tokens (#5843) * feat(Button): adds tokens and applies to buttons (#5908) * feat(table): apply tokens from hackathon (#5965) * feat(menu-toggle): add in work from hackathon (#5931) * feat(nav): adds tokens to page and nav (#5942) * chore(tokens): update tokens from figma (#5970) * feat(page): page and masthead updates from hackathon (#5968) * chore(v6): merge main into v6 (#5981) * fix(tokens): add dark theme blend mode token (#5992) * feat(notificationBadge): refactor with tokens (#5991) * chore(masthead ): applied tokens (#6004) * feat(alert): apply tokens (#6002) * feat(alert): apply tokens * feat(alert): remove unused background color * feat(page): apply tokens (#6021) * feat(page): apply tokens * feat(page): undo menu__list change * feat(page): tweak spacing * fix(table): fix clickable overlay (#6025) * fix(box-shadow): typo in box shadow token names (#6039) * fix(badge): adds tokens, dropdown toggle icon (#6037) * feat(hint): apply tokens (#6030) * feat(hint): apply tokens * feat(hint): fix typo * feat(hint): update spacing * feat(hint): update border radius * feat(hint): fix heading font --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Ashley Ray <123661468+ashley-o0o@users.noreply.github.com> Co-authored-by: Nicole Thoen <nthoen@redhat.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com> Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com> Co-authored-by: Sarah Rambacher <srambach@redhat.com> Co-authored-by: Matt Nolting <matthew.nolting@gmail.com> Co-authored-by: Jenny <32821331+jenny-s51@users.noreply.github.com>

* chore(select): fixed text in HTML example to show multiple checks can be selected (patternfly#5663) * chore: Update release.yml to node 18 [ci skip] * chore: add superclean npm script (patternfly#5798) * chore(options-menu): updated markup to match react component (patternfly#5809) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.3 (patternfly#5720) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): bump semver from 5.7.1 to 5.7.2 (patternfly#5756) Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: updated use of flex start/end to be more compatible (patternfly#5807) * fix(chip): add margin for badge when used in text element (patternfly#5844) * feat(global): added RTL support (patternfly#5778) * fix: added tree view icon (patternfly#5845) * fix: added tree view icon * chore: put treeviewicon in alphabetical order * chore: rtl fixes, screenshots (patternfly#5854) * chore: rtl fixes, screenshots * chore: checkin screenshots * chore(deps): update dependency @patternfly/documentation-framework to v5.1.7 (patternfly#5852) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: enable RTL switcher on full page examples (patternfly#5859) * docs: update location of and references to docs to consolidate and organize information. (patternfly#5773) * fix: added base, wizard, pagination RTL styles (patternfly#5860) * chore(Accordion,ExpandableSection): added more RTL styling (patternfly#5861) * fix(RTL): refactor mixins, add slider rtl styles (patternfly#5867) * fix(nav): added optional text wrapper for nav text (patternfly#5868) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.9 (patternfly#5863) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(Toolbar): updated toolbar pagination structure (patternfly#5862) * fix(breadcrumb): added rtl support (patternfly#5870) * chore(card): updated horiz demo image (patternfly#5875) * chore(Alert,NotificationDrawer): added additional rtl styling (patternfly#5866) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.10 (patternfly#5880) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(Nav, Menu): apply RTL fixes (patternfly#5873) * fix(clipboard-copy): added rtl styles (patternfly#5876) * fix(page): added rtl styles (patternfly#5878) * fix(calendar-month): rtl support (patternfly#5869) * chore(Card,Tile): apply RTL fixes (patternfly#5881) * fix: added tabs and jump links rtl styles (patternfly#5877) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.11 (patternfly#5885) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(DataList): added additional rtl styling (patternfly#5871) * chore(DataList): added additional rtl styling * Add comment to update notif badge in breaking change * fix(popover, tooltip): added rtl styles (patternfly#5882) * fix(tree-view): added rtl styles (patternfly#5883) * chore(Table): added additional RTL styling (patternfly#5887) * chore(Drawer): transforms and shadows on RTL drawer (patternfly#5888) * fix(forms): updated rtl styles (patternfly#5889) * fix(skeleton): added rtl styles (patternfly#5891) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.12 (patternfly#5894) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(slider): added root decl for var to create react token (patternfly#5895) * chore(ModalBox): center modal for workspace in RTL (patternfly#5893) * fix(rtl): fixes truncate rtl (patternfly#5874) * fix(ModalBox): fix centering on mobile (patternfly#5905) * chore: added backstop as dev dependency, update config (patternfly#5904) * chore(popover): center examples (patternfly#5906) * fix(nav): updated example css (patternfly#5903) * chore(deps): update dependency @patternfly/documentation-framework to v5.1.14 (patternfly#5909) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: remove workspace RTL classes (patternfly#5912) * chore: update screenshots (patternfly#5915) * fix: Update upload-preview.js to use new workspace url * chore(deps): update dependency @patternfly/documentation-framework to v5.1.15 (patternfly#5916) * chore(deps): update dependency @patternfly/react-table to v5.0.1 (patternfly#5914) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-code-editor to v5.0.1 (patternfly#5910) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-core to v5.0.1 (patternfly#5913) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: mirror fa-sort icon (patternfly#5920) * fix: mirror bg image position in rtl (patternfly#5922) * fix(progress): updated indicator direction (patternfly#5923) * chore: update readme to reference new workspace url * chore(deps): update dependency @patternfly/documentation-framework to v5.2.0 (patternfly#5925) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(code-editor): make code box and header LTR (patternfly#5928) * fix(code-editor): make code box and header LTR * chore: refactor to use dir instead of css for ltr on code block * fix(banner): fixed invalid dark theme color declaration (patternfly#5933) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.2 (patternfly#5934) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/documentation-framework to v5.2.3 (patternfly#5940) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(clipboard-copy): add code example with rtl support (patternfly#5941) * fix(card): removed border from clickable/selectable selected (patternfly#5935) * feat(Button): extended inline styling (patternfly#5696) * fix(menu): updated drilldown breadcrumb menu icons to work in RTL (patternfly#5924) * fix(toolbar): fix expand all icon in RTL (patternfly#5937) * chore(toolbar): mirror expand all icon in rtl * chore: update * chore: use icon shouldMirrorRTL param * fix(popover/tooltip): revert arrow logical prop positioning (patternfly#5952) * fix(popover/tooltip): revert arrow logical prop positioning * chore: add missing local css import * chore(screenshots): updated full page screenshots (patternfly#5960) * chore(deps): update dependency @patternfly/react-core to v5.1.1 (patternfly#5975) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps-dev): bump postcss from 8.4.27 to 8.4.31 (patternfly#5971) * chore(Toolbar): increase workspace container height (patternfly#5962) * chore(screenshots): update visual regression screenshots (patternfly#5959) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.17 (patternfly#5961) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-table to v5.1.1 (patternfly#5977) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/react-code-editor to v5.1.1 (patternfly#5974) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(check-radio): added aria-describedby to check/radio (patternfly#5969) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.18 (patternfly#5982) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(brand/card): update examples to display logo in dark theme (patternfly#5681) * fix(input): standardized check and radio alignment (patternfly#5947) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.19 (patternfly#5985) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @patternfly/documentation-framework to v5.2.20 (patternfly#5994) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): bump @babel/traverse from 7.22.15 to 7.23.2 (patternfly#6001) Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.22.15 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(Switch): updated focus style to focus-visible (patternfly#5995) * chore(menu-toggle): updated demos to use menu-toggle (patternfly#5782) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.24 (patternfly#6014) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat(Accordion): added left-aligned toggle variant (patternfly#5987) * chore(deps): update dependency @patternfly/documentation-framework to v5.2.26 (patternfly#6020) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: V6 merge main.10.30 (patternfly#6023) * chore(deps): update dependency @patternfly/documentation-framework to v5.3.0 (patternfly#6027) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(main): reverts to pre-v6 merge (patternfly#6038) * chore(deps): update dependency @patternfly/documentation-framework to v5.3.1 (patternfly#6040) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(globals): update invalid selector in global css (patternfly#6044) * feat(breaker): bump this version to 6.0 (patternfly#5800) BREAKING CHANGE: 6.0.0-alpha.0 * fix: white space change to kick off dry run * fix: use prerelease tag format with dry run * fix: turn off dryrun * feat(tokens): add initial global tokens (patternfly#5843) * feat(Button): adds tokens and applies to buttons (patternfly#5908) * feat(table): apply tokens from hackathon (patternfly#5965) * feat(menu-toggle): add in work from hackathon (patternfly#5931) * feat(nav): adds tokens to page and nav (patternfly#5942) * chore(tokens): update tokens from figma (patternfly#5970) * feat(page): page and masthead updates from hackathon (patternfly#5968) * chore(v6): merge main into v6 (patternfly#5981) * fix(tokens): add dark theme blend mode token (patternfly#5992) * feat(notificationBadge): refactor with tokens (patternfly#5991) * chore(masthead ): applied tokens (patternfly#6004) * feat(alert): apply tokens (patternfly#6002) * feat(alert): apply tokens * feat(alert): remove unused background color * feat(page): apply tokens (patternfly#6021) * feat(page): apply tokens * feat(page): undo menu__list change * feat(page): tweak spacing * fix(table): fix clickable overlay (patternfly#6025) * fix(box-shadow): typo in box shadow token names (patternfly#6039) * fix(badge): adds tokens, dropdown toggle icon (patternfly#6037) * feat(hint): apply tokens (patternfly#6030) * feat(hint): apply tokens * feat(hint): fix typo * feat(hint): update spacing * feat(hint): update border radius * feat(hint): fix heading font --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Ashley Ray <123661468+ashley-o0o@users.noreply.github.com> Co-authored-by: Nicole Thoen <nthoen@redhat.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Erin Donehoo <105813956+edonehoo@users.noreply.github.com> Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com> Co-authored-by: Sarah Rambacher <srambach@redhat.com> Co-authored-by: Matt Nolting <matthew.nolting@gmail.com> Co-authored-by: Jenny <32821331+jenny-s51@users.noreply.github.com>

patternfly-build · 2024-02-28T22:40:54Z

🎉 This PR is included in version 5.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

patternfly-build · 2024-05-01T14:57:28Z

🎉 This PR is included in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

mattnolting requested review from srambach, mcoker and thatblindgeye and removed request for srambach, mcoker and thatblindgeye July 26, 2023 16:50

thatblindgeye requested changes Jul 27, 2023

View reviewed changes

src/patternfly/components/MenuToggle/menu-toggle.hbs Outdated Show resolved Hide resolved

src/patternfly/components/MenuToggle/menu-toggle.hbs Outdated Show resolved Hide resolved

src/patternfly/components/Toolbar/toolbar-item-bulk-select.hbs Outdated Show resolved Hide resolved

mattnolting force-pushed the chore-menu-toggle-5764 branch 3 times, most recently from 45a2624 to f1c442b Compare August 9, 2023 20:14

mattnolting force-pushed the chore-menu-toggle-5764 branch from 5d772fe to be0c900 Compare August 15, 2023 14:37

mattnolting force-pushed the chore-menu-toggle-5764 branch 2 times, most recently from b0a0606 to 8cabf45 Compare September 6, 2023 18:44

mattnolting requested a review from thatblindgeye September 7, 2023 14:02

thatblindgeye approved these changes Sep 7, 2023

View reviewed changes

mcoker reviewed Oct 5, 2023

View reviewed changes

mattnolting requested a review from mcoker October 5, 2023 17:37

mattnolting force-pushed the chore-menu-toggle-5764 branch from 3d089e2 to c06eca9 Compare October 5, 2023 18:09

mcoker reviewed Oct 6, 2023

View reviewed changes

mattnolting force-pushed the chore-menu-toggle-5764 branch 3 times, most recently from 45f36df to 746e9e7 Compare October 11, 2023 11:59

mcoker requested changes Oct 18, 2023

View reviewed changes

mcoker mentioned this pull request Oct 18, 2023

Bug - Toolbar expanded content filter toggles should fill width #6008

Closed

chore(menu-toggle): updated demos to use menu-toggle

a942089

mattnolting added 4 commits October 19, 2023 11:12

chore(menu-toggle): resolved a11y issues

75857e2

chore(menu-toggle): updated list item roled

89cd1d3

update

4ef4020

chore(menu-toggle): removed widths

5375587

mattnolting force-pushed the chore-menu-toggle-5764 branch from 746e9e7 to 5375587 Compare October 20, 2023 15:57

mcoker approved these changes Oct 20, 2023

View reviewed changes

mcoker merged commit 466a5e5 into patternfly:main Oct 20, 2023
1 check passed

patternfly-build added the released on @prerelease label Oct 27, 2023

mattnolting added a commit to mattnolting/patternfly that referenced this pull request Dec 12, 2023

chore(menu-toggle): updated demos to use menu-toggle (patternfly#5782)

4d4b32e

patternfly-build added the released on @prerelease-bugfix label Feb 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(menu-toggle): updated demos to use menu-toggle #5782

chore(menu-toggle): updated demos to use menu-toggle #5782

mattnolting commented Jul 26, 2023

patternfly-build commented Jul 26, 2023 •

edited

thatblindgeye left a comment

mcoker left a comment

mcoker Oct 5, 2023

mcoker Oct 5, 2023

mcoker Oct 18, 2023

mcoker Oct 5, 2023

mattnolting Oct 5, 2023

mcoker Oct 18, 2023

mcoker commented Oct 6, 2023

mcoker Oct 6, 2023 •

edited

mcoker left a comment

mcoker Oct 18, 2023

mcoker Oct 18, 2023

mcoker left a comment

patternfly-build commented Oct 27, 2023

patternfly-build commented Feb 28, 2024

patternfly-build commented May 1, 2024

chore(menu-toggle): updated demos to use menu-toggle #5782

chore(menu-toggle): updated demos to use menu-toggle #5782

Conversation

mattnolting commented Jul 26, 2023

patternfly-build commented Jul 26, 2023 • edited

thatblindgeye left a comment

Choose a reason for hiding this comment

mcoker left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mcoker commented Oct 6, 2023

mcoker Oct 6, 2023 • edited

Choose a reason for hiding this comment

mcoker left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mcoker left a comment

Choose a reason for hiding this comment

patternfly-build commented Oct 27, 2023

patternfly-build commented Feb 28, 2024

patternfly-build commented May 1, 2024

patternfly-build commented Jul 26, 2023 •

edited

mcoker Oct 6, 2023 •

edited