GIT_ASK_YESNO/GIT_ASKPASS patches from Git for Windows #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@patthoyts any objections? |
|
@patthoyts do you see problems with this PR? |
|
@patthoyts any news? |
|
@patthoyts it would be nice to have some indication about the situation of Git GUI and how to contribute patches to it. |
|
@patthoyts hi! Could you please have a look and either merge or tell me what needs to be improved? |
|
@patthoyts ping? |
1 similar comment
|
@patthoyts ping? |
Make use of the new environment variable GIT_ASK_YESNO to support the recently implemented fallback in case unlink, rename or rmdir fail for files in use on Windows. The added dialog will present a yes/no question to the the user which will currently be used by the windows compat layer to let the user retry a failed file operation. Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
"Question?" is maybe not the most informative thing to ask. In the absence of better information, it is the best we can do, of course. However, Git for Windows' auto updater just learned the trick to use git-gui--askyesno to ask the user whether to update now or not. And in this scripted scenario, we can easily pass a command-line option to change the window title. So let's support that with the new `--title <title>` option. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
For additional GUI goodness. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
git-gui-askpass
branch
from
40067f8
to
1632458
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised, the next set of patches from Git for Windows' fork. These have been sitting there since 2010.
FWIW there is another patch we carry since 2010 and it seems that it still applies cleanly, but I am not at all sure whether it is correct. @patthoyts would you mind having a look at git-for-windows/git@87d88e8? It looks as if it was well-intentioned, somehow working around expected worktree settings that are, in fact, not always set. But I think that this is no longer the case. Could you tell me whether this assessment is correct?