Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed libphonenumber.js #247

Merged
merged 2 commits into from
Dec 17, 2018
Merged

Removed libphonenumber.js #247

merged 2 commits into from
Dec 17, 2018

Conversation

patw0929
Copy link
Owner

As #242 & #245, we don't need libphonenumber.js in this repo.
In future, please maintain libphonenumber.js at this repo.

@coveralls
Copy link

coveralls commented Dec 17, 2018

Coverage Status

Coverage remained the same at 94.158% when pulling 35cce22 on feature/remove-libphonenumber into 3b70c5d on master.

@patw0929
Copy link
Owner Author

This pull request introduces 2 alerts and fixes 2 when merging 8903e7d into 3b70c5d - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

fixed alerts:

  • 2 for Unneeded defensive code

Comment posted by LGTM.com

@nutboltu
Copy link
Collaborator

Lets add the webpack-bundle-analyzer and compare the bundle size

@patw0929
Copy link
Owner Author

This pull request fixes 2 alerts when merging 35cce22 into 3b70c5d - view on LGTM.com

fixed alerts:

  • 2 for Unneeded defensive code

Comment posted by LGTM.com

@patw0929
Copy link
Owner Author

Lets add the webpack-bundle-analyzer and compare the bundle size

Good point. I'll add it in another PR.

Copy link
Collaborator

@nutboltu nutboltu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice Work!

@patw0929 patw0929 merged commit 375c6bc into master Dec 17, 2018
@patw0929 patw0929 deleted the feature/remove-libphonenumber branch December 17, 2018 12:09
andrewsantarin pushed a commit to andrewsantarin/react-intl-tel-input that referenced this pull request Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants