Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove utilsScript prop #245

Merged
merged 3 commits into from
Dec 17, 2018
Merged

Remove utilsScript prop #245

merged 3 commits into from
Dec 17, 2018

Conversation

patw0929
Copy link
Owner

In #242, we import libphonenumber-js-utils dynamically (via chunk file).
Thus, we don't need to load libphonenumber.js ourselves via utilsScript prop anymore.

@superhit0
Copy link
Collaborator

LGTM

Copy link
Collaborator

@nutboltu nutboltu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good . We should maintain a CHANGELOG.md for the changes of upcoming release.

@patw0929 patw0929 merged commit f14488b into master Dec 17, 2018
@patw0929 patw0929 deleted the feature/remove-utilscript branch December 17, 2018 01:27
andrewsantarin pushed a commit to andrewsantarin/react-intl-tel-input that referenced this pull request Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants