Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the issue of pasting number to text input cannot update flag in international mode #270

Merged
merged 2 commits into from
Feb 7, 2019
Merged

Fixed the issue of pasting number to text input cannot update flag in international mode #270

merged 2 commits into from
Feb 7, 2019

Conversation

patw0929
Copy link
Owner

Description

As #252 said, when pasting a full number in international mode, the flag won't update.
But it works great when typing from the beginning.

In #252, @Samb102 provided their workaround which is called via ref.
This pull request is based on their workaround but without ref.

Screenshots (if appropriate):

Before fix:

After fix:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have used ESLint & Prettier to follow the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 93.401% when pulling e0a684b on feature/fix-paste-issue into ea1c29f on master.

@patw0929 patw0929 merged commit bd26b8f into master Feb 7, 2019
@patw0929 patw0929 deleted the feature/fix-paste-issue branch February 7, 2019 14:14
patw0929 added a commit that referenced this pull request Feb 7, 2019
@patw0929
Bumped version into v7.0.0
d043a1b 
Bug fixes

- #270: Fixed the issue of pasting number to text input cannot update flag in international mode
- #271: Fixed the CSS prop name issue of styled-component
andrewsantarin pushed a commit to andrewsantarin/react-intl-tel-input that referenced this pull request Feb 2, 2022
@patw0929
Merge pull request patw0929#270 from patw0929/feature/fix-paste-issue
cd7f9ca 
Fixed the issue of pasting number to text input cannot update flag in international mode
andrewsantarin pushed a commit to andrewsantarin/react-intl-tel-input that referenced this pull request Feb 2, 2022
@patw0929
Bumped version into v7.0.0
b01a319 
Bug fixes

- patw0929#270: Fixed the issue of pasting number to text input cannot update flag in international mode
- patw0929#271: Fixed the CSS prop name issue of styled-component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@patw0929 @coveralls