Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the CSS prop name issue of styled-component #271

Merged
merged 5 commits into from
Feb 7, 2019
Merged

Fixed the CSS prop name issue of styled-component #271

merged 5 commits into from
Feb 7, 2019

Conversation

patw0929
Copy link
Owner

@patw0929 patw0929 commented Feb 6, 2019

Description

As described in #264, we will got unexpected situation of CSS class name when using with styled-component.
The root cause is styled-component uses css prop too.
And for the better semantics of prop, we should replace css prop with containerClassName and inputClassName props.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have used ESLint & Prettier to follow the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@patw0929 patw0929 mentioned this pull request Feb 6, 2019
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.037% when pulling e0af43d on fix/t264 into ea1c29f on master.

nutboltu
nutboltu approved these changes Feb 7, 2019
View reviewed changes
Copy link
Collaborator

@nutboltu nutboltu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patw0929 patw0929 merged commit 367da63 into master Feb 7, 2019
@patw0929 patw0929 deleted the fix/t264 branch February 7, 2019 14:14
patw0929 added a commit that referenced this pull request Feb 7, 2019
@patw0929
Bumped version into v7.0.0
d043a1b 
Bug fixes

- #270: Fixed the issue of pasting number to text input cannot update flag in international mode
- #271: Fixed the CSS prop name issue of styled-component
andrewsantarin pushed a commit to andrewsantarin/react-intl-tel-input that referenced this pull request Feb 2, 2022
@patw0929
Merge pull request patw0929#271 from patw0929/fix/t264
31e1c7e 
Fixed the CSS prop name issue of styled-component
andrewsantarin pushed a commit to andrewsantarin/react-intl-tel-input that referenced this pull request Feb 2, 2022
@patw0929
Bumped version into v7.0.0
b01a319 
Bug fixes

- patw0929#270: Fixed the issue of pasting number to text input cannot update flag in international mode
- patw0929#271: Fixed the CSS prop name issue of styled-component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nutboltu nutboltu nutboltu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patw0929 @coveralls @nutboltu