fix: resolve node-gyp / node-sass errors on build #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcataford
commented
Aug 1, 2021
| @@ -1 +1 @@ | |||
| 10.18.0 | |||
| v12.22.4 | |||
There was a problem hiding this comment.
v10.x isn't supported anymore. ref
mcataford
commented
Aug 1, 2021
|
🎉 This PR is included in version 8.0.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
andrewsantarin
pushed a commit
to andrewsantarin/react-intl-tel-input
that referenced
this pull request
Feb 2, 2022
* build: set node to current maintenance version * build: node-sass bump * ci: minimum node * fix: typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It looks like
node-sasscrashed on build, which prevented going forward with some changes. Since the minimum Node version currently in maintenance is v12, this sets the minimum / preferred versions to that vianvm.node-sassis also bumped to the newest eligible version, which seems to solve the build issues.The Node version used in CI is also changed to match what we'd expect via
nvm.Types of changes