Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #46: Webpack UDM issue #47

Merged
merged 1 commit into from
Jan 2, 2019
Merged

Fixed #46: Webpack UDM issue #47

merged 1 commit into from
Jan 2, 2019

Conversation

patw0929
Copy link
Owner

@patw0929 patw0929 commented Jan 2, 2019

In v5.1.2, we upgraded webpack to v4, so we might get an error: window is not defined in SSR.
In webpack's issue, we found a workaround of this issue. (webpack/webpack#6522 (comment))

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.588% when pulling 60e20bb on fix/webpack4-window-issue into e5937b8 on master.

@patw0929 patw0929 merged commit 2191311 into master Jan 2, 2019
@patw0929 patw0929 deleted the fix/webpack4-window-issue branch January 2, 2019 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patw0929 @coveralls