matcher: disable updaters creates empty updater sets

Setting disable_updaters to true in the config should result in an empty
updaters sets list

Fixes quay#1273

Signed-off-by: Paul Aldridge <paulaldridge@uk.ibm.com>

config/config.go

@@ -64,6 +64,9 @@ func Validate(conf *Config) error {
 	if conf.HTTPListenAddr == "" {
 		conf.HTTPListenAddr = DefaultAddress
 	}
+	if conf.Matcher.DisableUpdaters {
+		conf.Updaters.Sets = []string{}
+	}
 	switch strings.ToLower(conf.Mode) {
 	case ComboMode:
 		if err := conf.Indexer.Validate(true); err != nil {

config/config_test.go

@@ -71,6 +71,69 @@ func Test_Config_Validate_Failure(t *testing.T) {
 	}
 }
 
+func Test_Config_Disable_Updaters(t *testing.T) {
+	var table = []struct {
+		name   string
+		conf   config.Config
+		expect bool
+	}{
+		{
+			name: "ComboMode, disable updaters",
+			conf: config.Config{
+				Mode:           config.ComboMode,
+				HTTPListenAddr: "localhost:8080",
+				Indexer: config.Indexer{
+					ConnString: "example@example/db",
+				},
+				Notifier: config.Notifier{
+					ConnString: "example@example/db",
+				},
+				Matcher: config.Matcher{
+					ConnString:      "example@example/db",
+					IndexerAddr:     "example@example/db",
+					DisableUpdaters: true,
+				},
+				Updaters: config.Updaters{
+					Sets: []string{
+						"alpine",
+						"aws",
+					},
+				},
+			},
+		},
+		{
+			name: "MatcherMode, disable updaters",
+			conf: config.Config{
+				Mode:           config.MatcherMode,
+				HTTPListenAddr: "localhost:8080",
+				Matcher: config.Matcher{
+					ConnString:      "example@example/db",
+					IndexerAddr:     "example@example/db",
+					DisableUpdaters: true,
+				},
+				Updaters: config.Updaters{
+					Sets: []string{
+						"alpine",
+						"aws",
+					},
+				},
+			},
+		},
+	}
+
+	for _, tab := range table {
+		t.Run(tab.name, func(t *testing.T) {
+			err := config.Validate(&tab.conf)
+			if err != nil {
+				log.Fatalf("expected no errors but got: %s", err)
+			}
+			if len(tab.conf.Updaters.Sets) != 0 {
+				log.Fatalf("expected updaters sets to be empty but was: %s", tab.conf.Updaters.Sets)
+			}
+		})
+	}
+}
+
 func TestAuthUnmarshal(t *testing.T) {
 	t.Run("PSK", func(t *testing.T) {
 		type testcase struct {