Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matcher disable updaters config not woking in v4.1.0 #1273

Closed
paulaldridge opened this issue May 21, 2021 · 0 comments · Fixed by #1274
Closed

Matcher disable updaters config not woking in v4.1.0 #1273

paulaldridge opened this issue May 21, 2021 · 0 comments · Fixed by #1274

Comments

@paulaldridge
Copy link
Contributor

Description of Problem / Feature Request

In relase v4.1.0 the code that checks the matcher config value of disable_updaters was removed, meaning that updaters will be enabled even with this value set to true.

Expected Outcome

Setting matcher.disable_updaters to true in the config sets the Updaters Sets value to an empty list, disabling updaters for this matcher instance.

Actual Outcome

Setting matcher.disable_updaters has no effect.

Environment

  • Clair version/image: v1.4.0
paulaldridge added a commit to paulaldridge/clair that referenced this issue May 21, 2021
@paulaldridge
matcher: disable updaters creates empty updater sets
aeb3f24 
Setting disable_updaters to true in the config should result in an empty
updaters sets list

Fixes quay#1273
@paulaldridge paulaldridge mentioned this issue May 21, 2021
Merged
paulaldridge added a commit to paulaldridge/clair that referenced this issue May 21, 2021
@paulaldridge
matcher: disable updaters creates empty updater sets
8f0893d 
Setting disable_updaters to true in the config should result in an empty
updaters sets list

Fixes quay#1273

Signed-off-by: Paul Aldridge <paulaldridge@uk.ibm.com>
paulaldridge added a commit to paulaldridge/clair that referenced this issue May 21, 2021
@paulaldridge
matcher: disable updaters creates empty updater sets
fedbe7e 
Setting disable_updaters to true in the config should result in an empty
updaters sets list

Fixes quay#1273

Signed-off-by: Paul Aldridge <paulaldridge@uk.ibm.com>
@hdonnay hdonnay changed the title Matcher disable updaters config not woking in v1.4.0 Matcher disable updaters config not woking in v4.1.0 May 24, 2021
paulaldridge added a commit to paulaldridge/clair that referenced this issue Jun 8, 2021
@paulaldridge
matcher: disable updaters creates empty updater sets
2da197d 
Setting disable_updaters to true in the config should result in an empty
updaters sets list

Fixes quay#1273

Signed-off-by: Paul Aldridge <paulaldridge@uk.ibm.com>
paulaldridge added a commit to paulaldridge/clair that referenced this issue Jun 8, 2021
@paulaldridge
matcher: disable updaters creates empty updater sets
bf637d0 
Setting disable_updaters to true in the config should result in an empty
updaters sets list

Fixes quay#1273

Signed-off-by: Paul Aldridge <paulaldridge@uk.ibm.com>
paulaldridge added a commit to paulaldridge/clair that referenced this issue Jun 8, 2021
@paulaldridge
matcher: disable updaters creates empty updater sets
b41994d 
Setting disable_updaters to true in the config should result in an empty
updaters sets list

Fixes quay#1273

Signed-off-by: Paul Aldridge <paulaldridge@uk.ibm.com>
paulaldridge added a commit to paulaldridge/clair that referenced this issue Jun 8, 2021
@paulaldridge
matcher: disable updaters creates empty updater sets
79f1a17 
Setting disable_updaters to true in the config should result in an empty
updaters sets list

Fixes quay#1273

Signed-off-by: Paul Aldridge <paulaldridge@uk.ibm.com>
paulaldridge added a commit to paulaldridge/clair that referenced this issue Jun 8, 2021
@paulaldridge
matcher: disable updaters creates empty updater sets
58759fc 
Setting disable_updaters to true in the config should result in an empty
updaters sets list

Fixes quay#1273

Signed-off-by: Paul Aldridge <paulaldridge@uk.ibm.com>
paulaldridge added a commit to paulaldridge/clair that referenced this issue Jun 8, 2021
@paulaldridge
matcher: disable updaters creates empty updater sets
517e3d6 
Setting disable_updaters to true in the config should result in an empty
updaters sets list

Fixes quay#1273

Signed-off-by: Paul Aldridge <paulaldridge@uk.ibm.com>
@hdonnay hdonnay closed this as completed in 49bfd4d Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

matcher: disable updaters creates empty updater sets paulaldridge/clair
1 participant
@paulaldridge