Merge pull request #534 from janka102/fix-#526

Fixed spaceless tag stripping too much (#526)
paularmstrong · Oct 31, 2014 · 90ac5cc · 90ac5cc
2 parents 73cb7c1 + f89b78e
commit 90ac5cc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 15 deletions.
diff --git a/lib/tags/spaceless.js b/lib/tags/spaceless.js
@@ -15,20 +15,12 @@ var utils = require('../utils');
  *
  */
 exports.compile = function (compiler, args, content, parents, options, blockName) {
-  function stripWhitespace(tokens) {
-    return utils.map(tokens, function (token) {
-      if (token.content || typeof token !== 'string') {
-        token.content = stripWhitespace(token.content);
-        return token;
-      }
+  var out = compiler(content, parents, options, blockName);
+  out += '_output = _output.replace(/^\\s+/, "")\n' +
+         '  .replace(/>\\s+</g, "><")\n' +
+         '  .replace(/\\s+$/, "");\n';
 
-      return token.replace(/^\s+/, '')
-        .replace(/>\s+</g, '><')
-        .replace(/\s+$/, '');
-    });
-  }
-
-  return compiler(stripWhitespace(content), parents, options, blockName);
+  return out;
 };
 
 exports.parse = function (str, line, parser) {

diff --git a/tests/tags/spaceless.test.js b/tests/tags/spaceless.test.js
@@ -7,8 +7,8 @@ var cases = [
   { c: '{% spaceless %} <p> foo </p> <p>bar</p> {% endspaceless %}', e: '<p> foo </p><p>bar</p>' },
   { c: '{% spaceless %}{% if true %}<p></p> <p></p>{% endif %}{% endspaceless %}', e: '<p></p><p></p>' },
   { c: '{% spaceless %}{% if false %}{% else %}<p></p> <p></p>{% endif %}{% endspaceless %}', e: '<p></p><p></p>' },
-  { c: '{% spaceless %}{% macro foo %}<p></p> <p></p>{% endmacro %}{% endspaceless %}{{ foo() }}', e: '<p></p><p></p>' },
-  { c: '{% macro foo %}<p></p> <p></p>{% endmacro %}{% spaceless %}{{ foo() }}{% endspaceless %}', e: '<p></p> <p></p>' }
+  { c: '{% spaceless %}{% macro foo %}<p></p> <p></p>{% endmacro %}{% endspaceless %}{{ foo() }}', e: '<p></p> <p></p>' },
+  { c: '{% macro foo %}<p></p> <p></p>{% endmacro %}{% spaceless %}{{ foo() }}{% endspaceless %}', e: '<p></p><p></p>' }
 ];
 
 describe('Tag: spaceless', function () {