more test #1
Merged
more test #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
paulbalandan
pushed a commit
that referenced
this pull request
Dec 15, 2021
…(paulbalandan) This PR was merged into the master branch. Discussion ---------- GetClassToClassKeywordFixer - introduction ``` $ php php-cs-fixer describe get_class_to_class_keyword` Description of get_class_to_class_keyword rule. Replace `get_class` calls on object variables with class keyword syntax. Fixer applying this rule is risky. Risky if the `get_class` function is overridden. Fixing examples: * Example #1. ---------- begin diff ---------- --- Original +++ New @@ -1,2 +1,2 @@ <?php -get_class($a); +$a::class; ----------- end diff ----------- * Example PHP-CS-Fixer#2. ---------- begin diff ---------- --- Original +++ New @@ -1,4 +1,4 @@ <?php $date = new \DateTimeImmutable(); -$class = get_class($date); +$class = $date::class; ----------- end diff ----------- ``` Commits ------- ee541a6 GetClassToClassKeywordFixer - introduction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please consider these tweaks and I think your PR on the main repo is good to go 👍 thanks for all the work!