Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should startScanningForDevicesAsync return a Stream<Device>? #2

Closed
pauldemarco opened this issue Jun 7, 2017 · 1 comment
Closed

Comments

@pauldemarco
Copy link
Owner

pauldemarco commented Jun 7, 2017

Right now you must both listen on deviceDiscovered() and initiate the method call with startScanningForDevicesAsync.

Consider combining this into:
Stream<Device> startScanningForDevices()

Simplifies API.

@pauldemarco
Copy link
Owner Author

Issue resolved during overhaul.

C4ptainCrunch added a commit to hastakecorp/flutter_blue that referenced this issue Jun 8, 2021
Squashed commit of the following:

commit bb6f0d1
Merge: 3a8c3ab 4670349
Author: Csaba Toth <csaba.toth.us@outlook.com>
Date:   Thu Mar 25 22:11:03 2021 +0100

    Merge pull request pauldemarco#2 from MrCsabaToth/master

    Refresh patch-1 branch with null safety newbies from master

commit 4670349
Merge: c19bb9a 7c7a86c
Author: Csaba Toth <csaba.toth.us@outlook.com>
Date:   Thu Mar 25 22:09:09 2021 +0100

    Merge pull request pauldemarco#1 from pauldemarco/master

    PR from main repo for null safety

commit 3a8c3ab
Author: Csaba Toth <csaba.toth.us@outlook.com>
Date:   Wed Mar 10 10:58:21 2021 -0800

    Bandaid fix pauldemarco#714
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant