Bandaid fix #714 #786
Closed
Bandaid fix #714 #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrCsabaToth
added a commit
to TrackMyIndoorWorkout/TrackMyIndoorWorkout
that referenced
this pull request
Mar 11, 2021
… by pauldemarco/flutter_blue#786 in my repo. Crash happens a lot out in the wild, release-only
PR from main repo for null safety
Refresh patch-1 branch with null safety newbies from master
C4ptainCrunch
added a commit
to hastakecorp/flutter_blue
that referenced
this pull request
Jun 8, 2021
Squashed commit of the following: commit bb6f0d1 Merge: 3a8c3ab 4670349 Author: Csaba Toth <csaba.toth.us@outlook.com> Date: Thu Mar 25 22:11:03 2021 +0100 Merge pull request #2 from MrCsabaToth/master Refresh patch-1 branch with null safety newbies from master commit 4670349 Merge: c19bb9a 7c7a86c Author: Csaba Toth <csaba.toth.us@outlook.com> Date: Thu Mar 25 22:09:09 2021 +0100 Merge pull request #1 from pauldemarco/master PR from main repo for null safety commit 3a8c3ab Author: Csaba Toth <csaba.toth.us@outlook.com> Date: Wed Mar 10 10:58:21 2021 -0800 Bandaid fix #714
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
channelis a type ofMethodChanneland is explicitly nulled out in thetearDownand is not initialized beforesetup. If we strictly look at the crash call stack the NPE comes inside therunfunction afterandroid.app.Activity.runOnUiThread. Maybe this is some race condition before thesetupor happens after atearDown. But it regularly comes from apps installed in the wild.