Skip to content

Commit

Permalink
Update gems and placate Rubocop with spaces after guard clauses
Browse files Browse the repository at this point in the history
  • Loading branch information
paulfioravanti committed Oct 4, 2018
1 parent c01e5a8 commit ccdebf5
Show file tree
Hide file tree
Showing 8 changed files with 15 additions and 7 deletions.
Empty file added .!21104!.tool-versions
Empty file.
14 changes: 7 additions & 7 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ GEM
bundler (~> 1.2)
thor (~> 0.18)
byebug (10.0.2)
codacy-coverage (2.0.1)
codacy-coverage (2.1.0)
simplecov
codeclimate-engine-rb (0.4.1)
virtus (~> 1.0)
Expand Down Expand Up @@ -78,7 +78,7 @@ GEM
json (2.1.0)
kramdown (1.17.0)
kwalify (0.7.2)
license_finder (5.4.0)
license_finder (5.4.1)
bundler
rubyzip
thor
Expand Down Expand Up @@ -117,7 +117,7 @@ GEM
rb-fsevent (0.10.3)
rb-inotify (0.9.10)
ffi (>= 0.5.0, < 2)
reek (5.0.2)
reek (5.1.0)
codeclimate-engine-rb (~> 0.4.0)
kwalify (~> 0.7.0)
parser (>= 2.5.0.0, < 2.6, != 2.5.1.1)
Expand All @@ -135,20 +135,20 @@ GEM
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.8.0)
rspec-support (3.8.0)
rubocop (0.58.2)
rubocop (0.59.2)
jaro_winkler (~> 1.5.1)
parallel (~> 1.10)
parser (>= 2.5, != 2.5.1.1)
powerpack (~> 0.1)
rainbow (>= 2.2.2, < 4.0)
ruby-progressbar (~> 1.7)
unicode-display_width (~> 1.0, >= 1.0.1)
rubocop-rspec (1.28.0)
rubocop-rspec (1.29.1)
rubocop (>= 0.58.0)
ruby-progressbar (1.10.0)
ruby_dep (1.5.0)
rubygems-tasks (0.2.4)
rubyzip (1.2.1)
rubyzip (1.2.2)
scrutinizer-ocular (1.0.1)
simplecov (>= 0.7)
shellany (0.0.1)
Expand Down Expand Up @@ -209,4 +209,4 @@ RUBY VERSION
ruby 2.5.1p57

BUNDLED WITH
1.16.4
1.16.5
1 change: 1 addition & 0 deletions lib/resume/cli/exception_suppressor.rb
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ def suppress(exception_to_ignore = StandardError, default = -> {})
# rubocop:disable Lint/RescueException
rescue Exception => exception
raise exception unless exception.is_a?(exception_to_ignore)

default.call
end
# rubocop:enable Lint/RescueException
Expand Down
2 changes: 2 additions & 0 deletions lib/resume/cli/font_downloader.rb
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ def audit_font_dependencies
# @return [nil]
def output_font_dependencies
return if fonts.none?

Output.warning(:custom_fonts)
end

Expand All @@ -66,6 +67,7 @@ def output_font_dependencies
# if the font file was not successfuly downloaded.
def fonts_successfully_downloaded?
return true if fonts.none?

fonts.all? do |font|
download_and_extract_font(font)
true
Expand Down
1 change: 1 addition & 0 deletions lib/resume/cli/font_extractor.rb
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ def extract_file(font, file)
def extract_entry(files, entry)
files.each_value do |filename|
next unless entry.name.match?(filename)

# `true` in the block ensures any existing files are overwritten
entry.extract(FileSystem.tmpfile_path(filename)) { true }
break
Expand Down
2 changes: 2 additions & 0 deletions lib/resume/cli/gem_installer.rb
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ def audit_gem_dependencies
# @return [Hash] The list of dependencies to install.
def output_gem_dependencies
return if gems.none?

Output.warning(:ruby_gems)
gems.each do |name, version|
Output.plain(:gem_name_and_version, name: name, version: version)
Expand All @@ -69,6 +70,7 @@ def output_gem_dependencies
# if gem dependencies were not successfully installed.
def gems_successfully_installed?
return true if gems.none?

Output.plain(:installing_ruby_gems)
gems.all? do |gem_name, version|
Kernel.system("gem", "install", gem_name, "-v", version)
Expand Down
1 change: 1 addition & 0 deletions lib/resume/cli/resume_node_types.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ module ResumeNodeTypes
# @param type [Class] The class type to check for `key`'s value.
def key_of_type?(hash, key, type)
return false unless hash.length == 1

hash.key?(key) && hash[key].is_a?(type)
end

Expand Down
1 change: 1 addition & 0 deletions lib/resume/pdf/entry/content.rb
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ def details(pdf, entry)

def profile(pdf, entry)
return unless (job_content = entry[:profile])

borders, height = entry[:cell_style].values_at(:borders, :height)
table_data =
job_content.reduce([]) do |content, responsibility|
Expand Down

0 comments on commit ccdebf5

Please sign in to comment.