Skip to content

Commit

Permalink
cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
paulirish committed Feb 25, 2017
1 parent 19ffbd8 commit 5d4ebb8
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
2 changes: 1 addition & 1 deletion bin/cli.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ const cliFlags = yargs
.epilogue('For more Lighthouse CLI options see https://github.com/GoogleChrome/lighthouse/#lighthouse-cli-options')
.argv;

const config = cliFlags.config ? getConfigFromFile(cliFlags.config) : {};
const config = getConfigFromFile(cliFlags.config);

//Merge options from all sources. Order indicates precedence (last one wins)
let options = Object.assign({}, {flags: cliFlags}, config);
Expand Down
1 change: 0 additions & 1 deletion lib/gsheets/gsheets.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ function authorize(credentials, callback) {
if (err) {
getNewToken(oauth2Client, callback);
} else {
debugger;
oauth2Client.credentials = typeof token === 'string' ? JSON.parse(token) : token;
callback(oauth2Client);
}
Expand Down
8 changes: 4 additions & 4 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -186,8 +186,8 @@ pwmetrics --submit
"sheets": {
"type": 'GOOGLE_SHEETS', // sheets service type. Available types: GOOGLE_SHEETS
"options": {
"spreadsheetId": "sheet-id",
"tableName": "my-sheeet-table-name",
"spreadsheetId": "sheet_id",
"tableName": "data",
"clientSecret": {
// Data object. Can be get by (using everything in step 1 here)[https://developers.google.com/sheets/api/quickstart/nodejs#step_1_turn_on_the_api_name]
}
Expand All @@ -210,8 +210,8 @@ module.exports = {
sheets: {
type: 'GOOGLE_SHEETS', // sheets service type. Available types: GOOGLE_SHEETS
options: {
spreadsheetId: 'sheet-id',
tableName: 'my-sheeet-table-name',
spreadsheetId: 'sheet_id',
tableName: 'data',
clientSecret: {
// Follow step 1 of https://developers.google.com/sheets/api/quickstart/nodejs#step_1_turn_on_the_api_name
// Then paste resulting JSON payload as this clientSecret value
Expand Down

0 comments on commit 5d4ebb8

Please sign in to comment.