Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AFNetworking 2.x support #3

Closed
EliSchleifer opened this issue Oct 24, 2014 · 9 comments
Closed

AFNetworking 2.x support #3

EliSchleifer opened this issue Oct 24, 2014 · 9 comments

Comments

@EliSchleifer
Copy link

No description provided.

@paulmelnikow
Copy link
Owner

Hi, for sure! I'd be happy to integrate them.

@EliSchleifer
Copy link
Author

Realizing while trying to put together the package that some definitions don't exist in AFNetworking 2.0 anymore. So we couldn't have the code live side by side unfortunately.

@paulmelnikow
Copy link
Owner

To keep it in one repository, maybe we could put the code in separate .[hm] files and use CocoaPods subspecs?

@EliSchleifer
Copy link
Author

Interesting idea. Never made a subspec in cocoapods

On Fri, Oct 24, 2014 at 3:44 PM, Paul Melnikow notifications@github.com
wrote:

To keep it in one repository, maybe we could put the code in separate
.[hm] files and use CocoaPods subspecs
http://guides.cocoapods.org/syntax/podspec.html#subspec?


Reply to this email directly or view it on GitHub
#3 (comment)
.

@syrakozz
Copy link

yes, it will be great if you can add your changes

@paulmelnikow
Copy link
Owner

@EliSchleifer Thanks so much for sharing this work back. I'd love to get this merged in and published since I think it will come in handy for a lot of people.

I pulled in the code from directr/AFNetworking-Synchronous into the afn2 branch (edit: now in master). Would you mind trying it out in your project and seeing if it works?

target 'AFNSync_Debug' do
  pod 'AFNetworking', "~> 2.0"
  pod 'AFNetworking-Synchronous/2.x', :git => 'https://github.com/paulmelnikow/AFNetworking-Synchronous', :branch => 'master'
end

By using subspecs, the 1.x and 2.x versions can coexist in the same repository.

@paulmelnikow paulmelnikow changed the title I have made updates to this library to work against AFNetworking 2.0 if you are interested AFNetworking 2.x support Dec 27, 2014
@paulmelnikow
Copy link
Owner

If you get a chance to try this, let me know how you make out!

@EliSchleifer
Copy link
Author

Hi Paul,

Sorry I didn't have a chance to look at this. Been kind of slammed and just
moved.

On Sat, Jan 3, 2015 at 8:40 PM, Paul Melnikow notifications@github.com
wrote:

If you get a chance to try this, let me know how you make out!


Reply to this email directly or view it on GitHub
#3 (comment)
.

@paulmelnikow
Copy link
Owner

No sweat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants