Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for a race condition on Linux #1228

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Jul 8, 2022

  1. test: Remove unnecessary unlink()s that led to brittle tests

    In two of the tests there were unlink() calls at the end of an
    asynchronously executed function. These calls would sometimes end
    up executing only after the test has finished and after cleanup,
    leading to them erroring out due to target files no longer around.
    
    These failures would cause exceptions reported in other, unrelated
    tests. Since the tests containing them work just fine without the
    unlink calls (as is evident by the fact that tests passed even if
    they executed after finishing the case) simply removing them fixes
    the problem and makes the test suite reliable.
    dividedmind committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    6bdda7f View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2022

  1. fix: Rescan directory after setting up watch to prevent a race

    Sometimes, when another process just happened to create a file
    when we were setting up a watch, the new file wouldn't be noticed.
    
    To prevent the event not being generated in this case, schedule
    a directory rescan immediately after setting up a watch.
    
    Fixes paulmillr#1112
    dividedmind committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    4f54121 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    95bc9cd View commit details
    Browse the repository at this point in the history