Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no events for symlinks with invalid targets #1253

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nathanael-ruf
Copy link

@nathanael-ruf nathanael-ruf commented Nov 21, 2022

Even with followSymlinks: false no events (e.g. 'add') were emitted for links with a target that doesn't exist.
Not sure about the changes / why we even need the realpath if followSymlinks: false. Also tests seem to fail (at least locally).
This is more like a draft PR so far (maybe someone can take over or suggest changes).

Steps to repro:

const chokidar = require('.');
chokidar.watch('tmp', {
    usePolling: true,
    followSymlinks: false
}).on('all', (e, p) => console.log(e, p));
ln -s does-not-exist link

test.js Outdated Show resolved Hide resolved
test.js Outdated Show resolved Hide resolved
@paulmillr paulmillr marked this pull request as ready for review September 17, 2023 13:58
@paulmillr paulmillr force-pushed the master branch 2 times, most recently from 368cb02 to 7c50e25 Compare February 6, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant