fix for #1011 #1289
Open
fix for #1011 #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulmillr
force-pushed
the
master
branch
2 times, most recently
from
368cb02
to
7c50e25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the call to ready() has been added to _addToNodeFs a bug has been introduced because it didn't consider that there
was already a call to _emitReady() in add and the result is that ready get dispatched before all paths are scanned
if one of them has errors.
I am trying to fix that here and I also refactored the catch block to better express the fact that the condition is always true
therefore there isn't a case in which ready() wouldn't have been called.