Extract binary filepath detection into separate modules #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -979,11 +979,4 @@ describe('is-binary', function() { | |||
| it('should be a function', function() { | |||
| isBinary.should.be.a('function'); | |||
| }); | |||
| it('should correctly determine binary files', function() { | |||
There was a problem hiding this comment.
These passed before I removed them. No point in having them here as they're in is-binary-path.
|
Thanks! LGTM |
es128
added a commit
that referenced
this pull request
Jan 24, 2015
Extract binary filepath detection into separate modules
|
Just a friendly FYI: I like using isBinaryFile for binary detection which doesn't rely on (hard to maintain) file extensions :) |
|
Yeah but proper detection with |
|
True, it hurts performance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've extracted the binary filepath detection into separate modules so other projects can benefit from the list of binary file extensions too.
https://github.com/sindresorhus/is-binary-path
https://github.com/sindresorhus/binary-extensions
I've added you both to the above modules on GitHub and npm.