Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native language for chokidar #272

Merged
merged 1 commit into from
Apr 1, 2015
Merged

Use native language for chokidar #272

merged 1 commit into from
Apr 1, 2015

Conversation

es128
Copy link
Collaborator

@es128 es128 commented Apr 1, 2015

Considering the origins of chokidar's name, this really seems like a more appropriate way to proceed with the codebase prior to releasing 1.0.0.

@paulmillr
Copy link
Owner

I love this idea!

paulmillr added a commit that referenced this pull request Apr 1, 2015
Use native language for chokidar
@paulmillr paulmillr merged commit 70cbea4 into master Apr 1, 2015
@stefanullinger
Copy link

Seriously?! Is this your April Fools Day contribution?

I can not read the source code anymore and I think many others can't either.
So you limit the number of contributors and users of this library, as no one wants to use a library he/she can not evaluate regarding code quality, or step through and understand what's happening while debugging.

Why not just minify the sources now? If you can not read/understand the variable names, then you can replace them with shorter words or single letters. This merged PR is bullshit and in combination with the amount of issues that came up in the last weeks it forces me to search for alternatives.

@es128
Copy link
Collaborator Author

es128 commented Apr 2, 2015

Lolololol

@stefanullinger
Copy link

Wrong language. I can still read your lol! xD

@floatdrop
Copy link

@es128 this broken everything on windows. Why would you do that?

@es128
Copy link
Collaborator Author

es128 commented Apr 4, 2015

  1. rc6 is a tagged release - npm should not provide it unless deliberately requested. You can see that if you npm install chokidar you get rc5. I also checked semver ranges like ^1.0.0-rc5 with npm update and it did not download rc6.
  2. The code should continue to work anyway. You can see that the tests passed.

So it wasn't quite as reckless as it may have appeared. Just trying to have a little fun obviously. Sorry that it upset that user who experienced issues.

@floatdrop
Copy link

@es128 I guess npm do download updates from rc releases (gulp-watch has ^1.0.0-rc2 in package). Jokes on me not to pin rc release 🐶

@es128
Copy link
Collaborator Author

es128 commented Apr 4, 2015

Alright well it wasn't my intention to cause disruption for anyone. Thanks for taking it in stride.

@paulmillr
Copy link
Owner

Just pulled it from NPM. Sorry again. A joke went too far 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants