Ignore files when using the 'cwd' option #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 13, 2015 02:37
| }) | ||
| ) | ||
| ); | ||
| if(!this._userIgnored){ |
There was a problem hiding this comment.
pls match code style on all the if statements (missing spaces)
|
Thanks! Just a few code style nits, but generally looks good for merge+publish. |
added 2 commits
July 14, 2015 01:21
- Refactor and simplify case where `cwd` and `ignored` options are used
es128
added a commit
that referenced
this pull request
Jul 14, 2015
Ignore files when using the 'cwd' option
taratatach
pushed a commit
to taratatach/chokidar
that referenced
this pull request
Oct 2, 2023
Bump license years
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a minor issue when files are not ignored when using
cwdoption withchokidar.watch, neither in thepathsparameter with paths starting with!, nor in theignoredproperty of theoptionsparameter.I fixed it jus taking care of the
cwdoption in the_isIgnoredfunction and change taking care of paths starting with!in theaddfunction whencwdis used.I also tested this feature in the cwd describe in the test.js.