Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to prevent path transformation #347

Closed
wants to merge 3 commits into from

Conversation

javiergarmon
Copy link

It fixes some issues like:

@paulmillr
Copy link
Owner

Whatsup with those tests?

@javiergarmon
Copy link
Author

Are you asking about Travis tests or are you asking to write some tests for this functionality?

@es128
Copy link
Collaborator

es128 commented Sep 6, 2015

The tests are failing because of a pre-existing issue in master with unwatch. Trying to find time to work on debugging it soon.

But nonetheless 👎 on merging this change. I agree it will alleviate some pain, but this is the easy way out and I believe it can be solved without adding a new option.

Even if we were to decide to incorporate this, yes it definitely would need new tests to cover the added feature.

@paulmillr paulmillr closed this Oct 13, 2015
@es128 es128 mentioned this pull request Oct 16, 2015
taratatach pushed a commit to taratatach/chokidar that referenced this pull request Oct 2, 2023
Update URLs pointing to constants in Apple docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants