🐜 Pass directory to the _getWatchedDir method
#588
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value of `wh.path` might be a glob, so we cannot safely pass it to `_getWatchedDir`. If we did that, a new entry in the `_watched` map would be created. Additionally, the call to `fs.readDir` would be passed a glob (undefined behavior?). This only applies when `options.useFsEvents` is false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of
wh.pathmight be a glob, so we cannot safely pass it to_getWatchedDir.If we did that, a new entry in the
_watchedmap would be created.Additionally, the call to
fs.readDirwould be passed a glob (undefined behavior?).This only applies when
options.useFsEventsis false.8 failing tests
Let me know if I'm misunderstanding something. 😄