Fix windows ignore when using anymatch@2 & cwd option #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes paulmillr#668 Chokidar@2 includes anymatch@2 which has a (potentially) breaking change as described in the changelog: https://github.com/micromatch/anymatch#change-log When the `cwd` is set Chokidar will join the ignore pattern to the cwd, and if this isn't absolute, it causes `anymatch` to fail: ```js // where cwd = c:\Users\remy\ anymatch('C:\\Users\\remy\\**\\node_modules\\**', 'C:\\Users\\remy\\node_modules\\project'); // === false ``` https://runkit.com/embed/rn05fobk294p So this change adds the upath module (used by Chokidar during testing and about 35K footprint) to normalize the path to bash-like slashes which corrects the issue.
|
@remy thank you! This looks good at a glance, I'll take a closer look later. |
|
Any joy on this PR? I saw the travis builds seem to bail every other build for some reason. |
|
Yeah that's just the flaky filesystems on Travis' OS X VMs. Typically just an annoyance. And Travis was having general issues when I tried to look the other day. The appveyor tests passed, which is the main thing that counts in this case. |
|
Cheers! What's the turnaround for publishing? (just asking so I know when to publish a bump to nodemon too - mine's just automated through travis atm) |
|
Been checking every now and then, and news on when/if this will be pushed to npm? Thanks. |
|
@remy sorry for the delay. Chokidar v2.0.1 with this fix is now published. |
|
🙏 thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #668
Chokidar@2 includes anymatch@2 which has a (potentially) breaking change
as described in the changelog: https://github.com/micromatch/anymatch#change-log
When the
cwdis set Chokidar will join the ignore pattern to the cwd,and if this isn't absolute, it causes
anymatchto fail:https://runkit.com/embed/rn05fobk294p
So this change adds the upath module (used by Chokidar during testing
and about 35K footprint) to normalize the path to bash-like slashes
which corrects the issue.