Unlink and re-add fails when multiple paths are passed #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
@paulmillr Any ideas on a fix for this failing test? |
srguiwiz
added a commit
to srguiwiz/chokidar
that referenced
this pull request
Jun 18, 2018
srguiwiz
added a commit
to srguiwiz/chokidar
that referenced
this pull request
Jun 18, 2018
es128
added a commit
that referenced
this pull request
Jun 19, 2018
Add tests to narrowly demonstrate defect mentioned in PR #682
paulmillr
added a commit
that referenced
this pull request
Sep 6, 2018
|
Is there any plan to fix the problem? |
|
Of course. Do you want to help us and create a fix for the problem? |
|
@paulirish I'll see if I could help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a second path to the watcher causes it to not pick up a re-add after an unlink (in non-polling and polling tests, fsevents still works). I tried poking around to find a fix but I'm not too familiar with the internals so I haven't found a solution yet. Watching directories does not have this issue.
This has proved problematic developing in Linux when switching branches and using webpack. A file that exists in one branch is removed on branch change and can no longer be watched when switching back to the initial branch.