Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependencies #719

Merged
merged 5 commits into from
May 21, 2018
Merged

Upgrade dependencies #719

merged 5 commits into from
May 21, 2018

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented May 21, 2018 •
edited

This fixes #715 related to security vulnerabilities reported by npm audit.

I've replaced istanbul by nyc (which is the latest version of istanbul).

I'm going to need some help with this PR for the following reasons:

  • 3 tests failed before I start this PR (i.e. not related to it), and still fail afterwards. That's why CI fails.
  • mocha hangs after testing. I'm not sure whether it's because of improper teardown in tests, or because of those failing tests. I've added the --exit flag to Mocha, which fixes the problem for the moment.
  • I don't have access to Coveralls, so I cannot make sure it works there (although it should)

@ehmicky ehmicky mentioned this pull request May 21, 2018
Closed
@coveralls
Copy link

coveralls commented May 21, 2018 •
edited

Coverage Status

Coverage decreased (-2.2%) to 96.322% when pulling a3316f7 on ehmicky:master into 8e5d416 on paulmillr:master.

@paulmillr paulmillr merged commit 5261384 into paulmillr:master May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New npm's audit feature complains a lot
3 participants
@ehmicky @coveralls @paulmillr