Adding failing Math.imul tests, and a fix.

Fixes #271.
paulmillr · Jul 15, 2014 · b74ceb2 · b74ceb2
1 parent 687d1a4
commit b74ceb2
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/es6-shim.js b/es6-shim.js
@@ -1059,6 +1059,8 @@
 
       imul: function(x, y) {
         // taken from https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/imul
+        x = ES.ToUint32(x);
+        y = ES.ToUint32(y);
         var ah  = (x >>> 16) & 0xffff;
         var al = x & 0xffff;
         var bh  = (y >>> 16) & 0xffff;

diff --git a/test/math.js b/test/math.js
@@ -369,6 +369,18 @@ describe('Math', function() {
       expect(Math.imul(1.9, 7)).to.equal(7);
       expect(Math.imul(7, 1.9)).to.equal(7);
     });
+
+    it('should be correct for objects with valueOf', function() {
+     var x = {
+       x: 0,
+       valueOf: function () { return ++this.x; }
+     };
+     expect(Math.imul(x, 1)).to.equal(1);
+     expect(Math.imul(1, x)).to.equal(2);
+     expect(Math.imul(x, 1)).to.equal(3);
+     expect(Math.imul(1, x)).to.equal(4);
+     expect(Math.imul(x, 1)).to.equal(5);
+    });
   });
 
   describe('Math.fround', function() {