Skip to content

Commit

Permalink
Revert of #251 - turns out this doesn't fix #240
Browse files Browse the repository at this point in the history
  • Loading branch information
ljharb committed Jun 4, 2014
1 parent b146748 commit e7a0f7a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions es6-shim.js
Original file line number Diff line number Diff line change
Expand Up @@ -758,7 +758,7 @@
},

getPropertyNames: function(subject) {
var result = Object.keys(subject);
var result = Object.getOwnPropertyNames(subject);
var proto = Object.getPrototypeOf(subject);

var addProperty = function(property) {
Expand All @@ -768,7 +768,7 @@
};

while (proto !== null) {
Object.keys(proto).forEach(addProperty);
Object.getOwnPropertyNames(proto).forEach(addProperty);
proto = Object.getPrototypeOf(proto);
}
return result;
Expand Down
4 changes: 2 additions & 2 deletions test/object.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ describe('Object', function() {
expect(Object.getPropertyNames(Object.create(null))).to.eql([]);
var obj = {};
expect(Object.getPropertyNames(Object.create(obj))).to.eql(
Object.keys(obj).concat(
Object.keys(Object.getPrototypeOf(obj))
Object.getOwnPropertyNames(obj).concat(
Object.getOwnPropertyNames(Object.getPrototypeOf(obj))
)
);
});
Expand Down

0 comments on commit e7a0f7a

Please sign in to comment.