Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object.assign erroneous TypeError #348

Closed
rwaldron opened this issue Jun 17, 2015 · 0 comments
Closed

Object.assign erroneous TypeError #348

rwaldron opened this issue Jun 17, 2015 · 0 comments

Comments

@rwaldron
Copy link
Contributor

This was exposed by @yanlxu's tests here: https://github.com/tc39/test262/pull/293/files

Ref:

if (!ES.TypeIsObject(target)) {

Object.assign must:

  • Coerce the target to an object, per ToObject
  • Throw a TypeError exception for cases that cannot be coerced, per ToObject
  • Apply the same semantics when there is only a target (this is pretty specific to es6-shim, but the patch will make it clear)
rwaldron added a commit to rwaldron/es6-shim that referenced this issue Jun 17, 2015
@ljharb ljharb closed this as completed in 26c1c6f Jun 17, 2015
ljharb added a commit that referenced this issue Jun 17, 2015
ljharb added a commit to ljharb/object.assign that referenced this issue Jun 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant