-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests don't work in cloud due to global expect #67
Comments
feel free to create files like |
I guess what I'm saying is, why do we have the index.html at all? The order of importance for testing environments imo is node, travis, testling/jepso/browser test clouds, and then maybe a local html file. |
How to test stuff locally without this file? |
done? |
That's an improvement :-) testling now says |
Also, |
To test stuff locally, we'd use browserify locally to generate the assets (with node-style requires) and keep the html file. In order to do that, though, it needs to first work on the command line with |
npm tests fixd |
Fixed all this in pull request #152. |
I think that worrying about index.html for tests is a problem. It forces, in particular, relying on a global "expect" to be set (that test_helpers sets for command-line). It makes testling tests fail, and I can only assume jepso tests as well.
I think that it would be better to eliminate the HTML entirely, or at least, use browserify to output all the JS for the html file (and store it in the repo if necessary). That way, the tests could be tweaked to only work in a node environment, but the html file would still be usable if someone wanted it (although I'm not sure why they would).
Thoughts?
The text was updated successfully, but these errors were encountered: