Tests don't work in cloud due to global expect

[ljharb]

I think that worrying about index.html for tests is a problem. It forces, in particular, relying on a global "expect" to be set (that test_helpers sets for command-line). It makes testling tests fail, and I can only assume jepso tests as well.

I think that it would be better to eliminate the HTML entirely, or at least, use browserify to output all the JS for the html file (and store it in the repo if necessary). That way, the tests could be tweaked to only work in a node environment, but the html file would still be usable if someone wanted it (although I'm not sure why they would).

Thoughts?

[paulmillr]

feel free to create files like browser-helpers.js and browser-initialize.js for that

[ljharb]

I guess what I'm saying is, why do we have the index.html at all? The order of importance for testing environments imo is node, travis, testling/jepso/browser test clouds, and then maybe a local html file.

[paulmillr]

How to test stuff locally without this file?

[paulmillr]

done?

[ljharb]

That's an improvement :-) testling now says ReferenceError: Can't find variable: chai on line 866 on http://git.testling.com/work/paulmillr/repos/31b9315f6a7bd0a3fbb26dc58117e9431a930012.1368770165025/1368770165211.2d094fdc.html

[ljharb]

Also, npm test now doesn't work on the command-line. I get ReferenceError: window is not defined in test/browser-onload.js

[ljharb]

To test stuff locally, we'd use browserify locally to generate the assets (with node-style requires) and keep the html file. In order to do that, though, it needs to first work on the command line with npm test, and I'm not sure how to do that without first decimating the HTML file

[paulmillr]

npm tests fixd

[cscott]

Fixed all this in pull request #152.