Increases strictness of type checker. #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a check that ensures every function with a return statement returns from all code paths. There was one place where this wasn't happening, which was fixed. Added `node_modules` and `package-lock.json` to `.gitignore`. I'm not sure why `node_modules` wasn't present. I also added `package-lock.json` because I know the maintainers don't commit it, though I personally think it should be committed so builds are reliably reproducible. Added vscode setting to use locally installed TS when using this project, rather than globally installed.
I have global gitignore for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few minor changes here. I can split them up into multiple PRs if desired, but since they are all individually so tiny I figured it would be reasonable to throw them all into one.
Adds a check that ensures every function with a return statement returns from all code paths. There was one place where this wasn't happening, which was fixed.
Added
node_modulesandpackage-lock.jsonto.gitignore. I'm not sure whynode_moduleswasn't present.I also added
package-lock.jsonbecause I know the maintainers don't commit it, though I personally think it should be committed so builds are reliably reproducible.Added vscode setting to use locally installed TS when using this project, rather than globally installed.