New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

including default value for ADD argument in webcrypto aes-gcm algorithm #34

Merged

paulmillr merged 2 commits into paulmillr:main from antonioconselheiro:bugfix/aes-gcm-missing-argument-for-webcrypto

Apr 29, 2024

Contributor

antonioconselheiro commented Apr 28, 2024

Solves #33


          including default value for ADD argument in webcrypto aes-gcm algorithm

3dd2734

antonioconselheiro mentioned this pull request

AES-GCM integration with webcrypto brakes when optional param not sent #33

Closed

Owner

paulmillr commented Apr 28, 2024

We shouldn't pass uint8array(0). Instead, delete this property from the object when it's not present


          removing additionalData for AES-GCM when undefined

f805739

paulmillr merged commit 9f0a098 into paulmillr:main

mrhrobertson mentioned this pull request

[Snyk] Upgrade @noble/ciphers from 0.4.1 to 0.5.3 mrhrobertson/furnace#3

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment