Add decaf448 #59
Add decaf448 #59
Conversation
|
nice :) |
| 'f063769e4241e76d815800e4933a3a144327a30ec40758ad3723a788388399f7b3f5d45b6351eb8eddefda7d5bff4ee920d338a8b89d8b63', | ||
| '5a0104f1f55d152ceb68bc138182499891d90ee8f09b40038ccc1e07cb621fd462f781d045732a4f0bda73f0b2acf94355424ff0388d4b9c', | ||
| ]; | ||
| for (const badBytes of badEncodings) { |
There was a problem hiding this comment.
there's nothing like a should.each ?
There was a problem hiding this comment.
I guess if you really wanted to, you can just do "arr.forEach((e, i) => should(something - ${i} - ${e}, " but then again "throws(() => something(b), badBytes)" will report the exact culprit. So yeah
| deepStrictEqual(point.toHex(), encodedHashToPoints[i]); | ||
| } | ||
| }); | ||
| should('have proper equality testing', () => { |
There was a problem hiding this comment.
This is just for testing DecafPoint#equals ?
There was a problem hiding this comment.
Jup, basic testing of the equals method (based on the RistrettoPoint one).
|
This is great! |
|
Tests seem to be failing. |
Forgot to run prettier on the files, should be fixed now. |
|
Add benchmarks please and we're good to go. |
|
Also, README docs. |
Based on draft-irtf-cfrg-ristretto255-decaf448-07, draft-irtf-cfrg-hash-to-curve-16 and the ristretto255 implementation. Signed-off-by: Stefan Knoblich <stkn@bitplumber.de>
Signed-off-by: Stefan Knoblich <stkn@bitplumber.de>
Signed-off-by: Stefan Knoblich <stkn@bitplumber.de>
Signed-off-by: Stefan Knoblich <stkn@bitplumber.de>
|
Thanks! In the future, please don't force-push: this requires me to re-review all files for the second time, instead of just watching new/diff commits. If you wanted to ensure history cleanliness, it's good, but no need: I can always squash-merge a PR if it gets too messy. |
|
Nice! can use this for voprf |
Based on draft-irtf-cfrg-ristretto255-decaf448-07, draft-irtf-cfrg-hash-to-curve-16 and the ristretto255 implementation.