Add verification of BLS short signatures #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, that should work. Keygen and sig gen would also be great! |
|
This is ready for review |
|
thanks |
|
@randombit could you also update README docs, please? |
|
@paulmillr Sure, I will open another PR on Monday. Thanks for the fast merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I work on a system that uses BLS with short signatures (ie signatures in G1 and public keys in G2). We'd like to be able to use this library to verify such signatures.
Does my current change seem like the general direction of something you would accept? If so I will add also aggregation support, and of course tests. (And also if you want, keygen and signature generation - I don't think we need those but if you want them for parity that certainly is understandable.)
If the approach I'm taking here is not what you would want, just let me know what you're looking for and I'll do that instead!
Related - #64