Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mod.ts file to export etc #82

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Conversation

quentinadam
Copy link
Contributor

I am suggesting the following minor changes :

  • Export etc in mod.ts.
  • Use the export { ... } from '...' syntax instead of import {...} from '...'; export { ... }

@paulmillr
Copy link
Owner

is mod.ts even needed? People can just use index.ts

@quentinadam
Copy link
Contributor Author

It’s obviously not strictly needed but somewhat more conventional on Deno.

@paulmillr
Copy link
Owner

I don't remember why I did not do export in the first phase. It was probably related to types or something like that.

@paulmillr
Copy link
Owner

so we can merge this, but only the etc part; export needs to be reverted

@quentinadam
Copy link
Contributor Author

I have reverted the export part.

@paulmillr paulmillr merged commit 6381c0b into paulmillr:main Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants