Improve error message for invalid privkey length #97
Conversation
|
How about we keep one error, but make it more descriptive e.g. "Uint8Array of valid length expected"? |
Personally I think the separate error messages are a bit more helpful because it tells you exactly what the problem is without further investigation, although a single descriptive message would still be an improvement. I just helped a colleague through debugging this error and only figured out it was due to length (passing 64 bytes instead of 32 due to decoding a hex string as utf8 earlier in the code) after many sanity checks that the variable we were passing was, in fact, a Uint8array. "Uint8Array of valid length expected" would've helped but "Invalid Uint8Array length" would've saved us one more check. That said, it's your repo so I can change this to "Uint8Array of valid length expected" if you think that's best. Thanks for all your excellent cryptography libraries. |
|
yes, please change to my suggested format |
This adds detail to the error message when a Uint8Array is provided as a privkey but it does not have the correct length. Previously, the error message stated only "Uint8Array expected" - which is confusing because a Uint8Array was in fact provided. This should make debugging invalid privkeys easier. A test case is added that checks for the new error message.
Done. |
This adds a more specific error message when a Uint8Array is provided for a privkey but it does not have the correct length. Previously, the error message stated "Uint8Array expected" - which is confusing because a Uint8Array was in fact provided. This should make debugging invalid privkeys easier.
A test case is added that checks for the new error message.