Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add main/module fields to package.json #37

Merged
merged 1 commit into from Dec 12, 2021
Merged

Add main/module fields to package.json #37

merged 1 commit into from Dec 12, 2021

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Dec 12, 2021

With package root imports relies on the main/module fields, see https://github.com/jacogr/test-noble-packaging (parcel/webpack bundles correctly, browserify needs the main field otherwise it doesn't find it)

@paulmillr paulmillr merged commit 4544cbb into paulmillr:main Dec 12, 2021
@paulmillr
Copy link
Owner

Same with noble hashes pls

@jacogr
Copy link
Contributor Author

jacogr commented Dec 12, 2021

@noble/hashes do work since we don't import from root package, rather via lib/blake2 etc. Or at least, the above linked repo only complains on secp256k1, no issues on hashes in there. (However, it we ever do export everything from index.ts as well, the same should be applied)

@jacogr jacogr deleted the jg-main-module-package branch December 12, 2021 07:37
@achingbrain
Copy link

Any chance of this being released please? It should fix builds that use browserify.

This was referenced Dec 13, 2021
@paulmillr
Copy link
Owner

1.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants