Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speedup non-BASE multiplyAndAddUnsafe #54

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Speedup non-BASE multiplyAndAddUnsafe #54

merged 1 commit into from
Mar 15, 2022

Conversation

brandonblack
Copy link
Contributor

When a non-cached this, or a <= 1 is passed, use multiplyUnsafe
instead of precomputed windowed multiply.

@reardencode
Speedup non-BASE multiplyAndAddUnsafe
3dc0cd9 
When a non-cached `this`, or `a` <= 1 is passed, use `multiplyUnsafe`
instead of precomputed windowed `multiply`.
@brandonblack
Copy link
Contributor Author

This change makes multiplyAndAddUnsafe conveniently usable for various tweaking operations in MuSig, and brings it more in line with other (ie. libsecp256k1) utility for non-BASE P.

@paulmillr paulmillr merged commit 97aa518 into paulmillr:main Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brandonblack @paulmillr @reardencode