Merge pull request #28 from mahnunchik/bech32-limit

fix: bech32 prefix length
paulmillr · Dec 14, 2023 · eef8051 · eef8051
2 parents c5cbf7b + 2832b64
commit eef8051
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/index.ts b/index.ts
@@ -482,6 +482,7 @@ function genBech32(encoding: 'bech32' | 'bech32m') {
       throw new Error(`bech32.encode prefix should be string, not ${typeof prefix}`);
     if (!Array.isArray(words) || (words.length && typeof words[0] !== 'number'))
       throw new Error(`bech32.encode words should be array of numbers, not ${typeof words}`);
+    if (prefix.length === 0) throw new TypeError(`Invalid prefix length ${prefix.length}`);
     const actualLength = prefix.length + 7 + words.length;
     if (limit !== false && actualLength > limit)
       throw new TypeError(`Length ${actualLength} exceeds limit ${limit}`);

diff --git a/test/bech32.test.js b/test/bech32.test.js
@@ -68,6 +68,15 @@ const BECH32_INVALID_DECODE = [
 ];
 
 const BECH32_INVALID_ENCODE = [
+  {
+    prefix: '',
+    words: [],
+  },
+  {
+    prefix:
+      'abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzfoobar',
+    words: [],
+  },
   {
     prefix: 'abc',
     words: [128],
@@ -181,6 +190,15 @@ const BECH32M_INVALID_DECODE = [
 ];
 
 const BECH32M_INVALID_ENCODE = [
+  {
+    prefix: '',
+    words: [],
+  },
+  {
+    prefix:
+      'abcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzabcdefghijklmnopqrstuvwxyzfoobar',
+    words: [],
+  },
   {
     prefix: 'abc',
     words: [128],