Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed-up hex using noble technique. #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Speed-up hex using noble technique. #30

wants to merge 1 commit into from

Conversation

paulmillr
Copy link
Owner

The PR makes hex decoding 23x faster on 8KB inputs.

The cost: +40 lines of code.

Should we do it? Is hex a bottleneck?

@arobsn
Copy link

arobsn commented Jun 21, 2024

I think it's a really small price to pay for such a big performance improvement.

@paulmillr
Copy link
Owner Author

@arobsn is it relevant to your use case? Is it a bottleneck in your case?

@paulmillr
Copy link
Owner Author

I mean, we can speed-up every function, but that would make package big. If we speed up only some functions, we need to select which ones.

@arobsn
Copy link

arobsn commented Jun 23, 2024

I usually avoid using it because it's too slow, but yes, not really an issue for my use case. My point is that 40 lines of code is a good price to pay for a 23x performance boost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants