Fixes to Makefile + minor tweaks (fixes #2) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 'get' and 'format' targets to the Makefile according to the existing documentation in the README.md, as well as 'all' as the first target which runs both (i.e. when make is called with no args). Commented out call to 'check-logins.coffee' since it is apparently just a debug thing which doesn't work the first time due to an ordering problem (needs data which doesn't get generated until later). This, along with earlier commit which checks that temp-logins.json exists before trying to rename it to old-logins, fixes paulmillr#2 (paulmillr#2) Now running 'make' out of the box after cloning and installing deps should just work... Also added a 'clean' target to the Makefile for good measure, and just as a means to document the list of files that are expected to be generated from get/format Also updated the request error handling code to throw the body text in addition to the status (useful to be able to see if the error is because you've run afoul of Github's rate limit rules). Finally, split url string in get-users.coffee into two lines for readability.
paulmillr
added a commit
that referenced
this pull request
Jul 29, 2014
Fixes to Makefile + minor tweaks (fixes #2)
|
thx |
cmrnh
pushed a commit
to cmrnh/github-stats
that referenced
this pull request
Dec 31, 2014
Fixes to Makefile + minor tweaks (fixes paulmillr#2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'make' should work now out of the box (and support 'get' and 'format' targets like the docs already described). Should still preserve the author's existing process/workflow (i.e. make 1, make 2 ...). See commit messages for more info.