code cleanup, added settings item

Controller/Admin.php

@@ -2,6 +2,9 @@
 
 namespace EmailOnSave\Controller;
 
+/**
+ * Admin class.
+ */
 class Admin extends \Cockpit\AuthController {
 
   public function index() {

actions.php

@@ -1,7 +1,7 @@
 <?php
 
 
-$app->on('collections.save.after', function($name, $data) use($app) {
+$app->on('collections.save.after', function ($name, $data) use ($app) {
 
   $settings = $app->storage->getKey('cockpit/options', 'emailonsave.settings', []);
 
@@ -45,4 +45,4 @@
     );
 
   }
-});
+});

admin.php

@@ -1,19 +1,18 @@
 <?php
 
-// ACL
+// ACL.
 $this("acl")->addResource('EmailOnSave', ['manage.emailonsave']);
 
-$app->on('admin.init', function() {
+/*
+ * add menu entry if the user has access to group stuff
+ */
+$this->on('cockpit.view.settings.item', function () {
+  if ($this->module('cockpit')->hasaccess('EmailOnSave', 'manage.emailonsave')) {
+    $this->renderView("emailonsave:views/partials/settings.php");
+  }
+});
 
-    // bind admin routes /emailonsave
-    $this->bindClass('EmailOnSave\\Controller\\Admin', 'emailonsave');
-
-    // add to modules menu
-    $this('admin')->addMenuItem('modules', [
-        'label' => 'Email On Save',
-        'icon'  => 'assets:app/media/icons/email.svg',
-        'route' => '/emailonsave',
-        'active' => strpos($this['route'], '/emailonsave') === 0
-    ]);
-
-});
+$app->on('admin.init', function () use ($app) {
+  // Bind admin routes /settings/email-on-save.
+  $this->bindClass('EmailOnSave\\Controller\\Admin', 'settings/email-on-save');
+});

bootstrap.php

@@ -1,9 +1,9 @@
 <?php
 
-// ADMIN
+// ADMIN.
 if (COCKPIT_ADMIN && !COCKPIT_API_REQUEST) {
-    include_once(__DIR__ . '/admin.php');
+  include_once __DIR__ . '/admin.php';
 }
 
-// ACTIONS
-include_once(__DIR__ . '/actions.php');
+// ACTIONS.
+include_once __DIR__ . '/actions.php';

views/partials/settings.php

@@ -0,0 +1,19 @@
+<?php
+
+/**
+ * @file
+ * Logger settings entry view.
+ */
+?>
+
+<div>
+    <div class="uk-panel uk-panel-space uk-panel-box uk-panel-card">
+
+        <img src="@url('assets:app/media/icons/email.svg')" width="50" height="50" alt="@lang('Email on Save')" />
+
+        <div class="uk-text-truncate uk-margin">
+            @lang('Email on Save')
+        </div>
+        <a class="uk-position-cover" href="@route('/settings/email-on-save')"></a>
+    </div>
+</div>

views/settings/index.php

@@ -52,7 +52,7 @@
 
         <div class="uk-width-medium-1-2">
             <button class="uk-button uk-button-large uk-width-1-3 uk-button-primary uk-margin-right">@lang('Save')</button>
-            <a href="@route('/')">@lang('Cancel')</a>
+            <a href="@route('/settings')">@lang('Cancel')</a>
         </div>
 
     </form>