Added incremental reveal #13
Conversation
| function setSlide(i) {views.present.postMessage("setSlide(" + i + ")", "*"); } | ||
| function back() {views.present.postMessage("back", "*");views.remote.postMessage("back", "*"); } | ||
| function forward() {views.present.postMessage("forward", "*");views.remote.postMessage("forward", "*"); } | ||
| function setSlide(i) {views.present.postMessage("setSlide(" + i + ")", "*");} |
There was a problem hiding this comment.
Why do need to do that? I don't think you need to.
There was a problem hiding this comment.
I put the incremental code in the forward/back functions within template.html, but the onstage.html only triggered the "present" view's functions and not the "remote" view's
There was a problem hiding this comment.
- you assume views.remote exists. You should not.
- if you do that, then you should remove the initial remote.postMessage(setSlide)
I think it would be better to keep the current behavior but to extend to notion of "idx".
Maybe it could be a string instead of a number, that could look like that:
4.3.8 (slide number 4, 3rd element of the 1st level of "incrental" element, 8th element of the 2nd level of "incrental" element, ...)
There was a problem hiding this comment.
I had a similar idea but I don't understand why you would want n parts in this system.
In my mind there's just back and forward so one number for slide idx and one number for "inslide" step should be enough.
Incremental elements could be identified as a ordered list that can be revealed one at a time.
There was a problem hiding this comment.
So you could post a command setSlide(slideNumber, incrementNumber (optional))? Sounds like a good idea, the only problem would be making sure views.future is always one ahead, but I guess you want it showing the next slide, not the next bullet point so setSlide(slideNumber+1) would work fine.
My initial reason for adding these lines was because onstage.html only posts forward()/back() commands to views.present, and then only when views.present changes slide does it post (a setSlide() command) to views.future/views.remote. Wouldn't it be simpler to just send any forward()/back() command sto all views currently connected?
There was a problem hiding this comment.
I totally agree with you Philip, the way present and remote views are handled is strange. They should be synchronized and receive back/forward commands. Present should send message to onstage containing details of current slide.
About future view, I think it just needs to display next slide without changing steps. Maybe displaying the slide like if it were already incremented to the end...
Present view could also inform you how many steps remains before next slide...
There was a problem hiding this comment.
Re-doing the communication is really a separate, much bigger, question. I'll open a new issue on it.
|
I've added a test implementation of |
|
I didn't understand that you wanted to keep .incremental for ul/ol and .incremental-list for other container elements. It looks strange to me. We should have :
I still think that sortIncrement() is not needed and that we can retrieve all elements that needs to be incremented. Did you have a look at my implementation ? Have a look at my commit (hsablonniere/dzslides@2ae40b35db997c1c05cb) and tell me what you think... |
|
I kept them so that, currently, both could be experimented with. I like your way of doing it, it really comes down to a personal preference. I did it my way as the css is more user friendly (no ":not" selectors) and the javascript CSS query is simpler so might be very slightly quicker, I realise I'm probably gaining less than a faction of a millisecond.... The disadvantages of my method (and the advantages of yours) are that I have to have this one off function added in at the start. |
|
We could flip a coin ;-) More seriously, I don't really mind which implementation we use if we have the same result working like I described earlier. Maybe Paul could arbitrate... |
|
I'm kind of lost in this discussion :) |
|
I guess it is getting a little crowded :) Issue #9 seems like good neutral ground to discuss it, I'll try and condense my method and put a post there, and if hsablonniere does the same that'll be a good starting place. |
|
Works for me. Hubert, can you summarize your work there as well? BTW, thank you guys to take the time to fix this issue ;) |
|
Sorry for the mess, I'm kinda lost too :p Summary : done! |
… is now the preferred method
Paul,
Love dzslides, but quite needed the powerpoint style reveal one-by-one. So I added it.
It can be styled by three classes:
incremental - nodes to be shown
current - node most recently shown
incremented - nodes that have be shown
I've change slide three of template.html to give an example.
Also onstage.html had to be tweaked to send the "forward()" and "back()" messages to the remote view, not just local.
Thanks for the great resource,
Phil Ingrey