Various small bugfix and improvements #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
robomics
commented
Jun 2, 2022
robomics
commented
- Bump dependencies
- Update CI
- Bugfix to CLI
- Address clang12 warnings
- Remove unused header
Address a bug that caused the rev/fwd extrusion speed to not be updated based on the bin size passed through the --resolution option. I decided to update the integration test script to use 2.5kbp as average extrusion speed instead of updating the test dataset. The main motivation is to limit repository bloat due to many revision of (relatively) large binary files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.